[RFC] Convert OpenSlide-Java Makefile to Autotools #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JNI code stores a pointer inside a jlong, causing warnings on 32-bit systems. Silence these.
Fixes autoreconf failure.
On Linux, the JNI library will likely not be in the library search path. Load it by its full path in this case.
If --host is passed to configure but --build is not, configure will guess whether we are cross-compiling based on whether it can run a compiled executable. If the build system is configured to run Windows executables via Wine, this test can fail.
|
I have decided against point 2. Debian policy also requires the JAR filename to include the package version and an unversioned symlink to be created, which doesn't make sense for us upstream. While the packaging scripts are doing this, they can move the JAR to the desired directory. |
|
I think that's the last of it. Without objection, I will merge this soon. |
bgilbert
added a commit
that referenced
this pull request
Nov 1, 2011
Convert OpenSlide-Java Makefile to Autotools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to improve the Makefile to automatically detect include directories and compiler flags, but it became apparent that I was reimplementing Autoconf. So, here is a conversion of OpenSlide-Java to Autotools. Makefile.am is responsible for
make dist(which we haven't had before) and for building the JNI, and still calls out to Ant for building the jar. All of the stuff frommingw32-cheatsheet.txtis handled automatically if--hostis passed to configure. Tested on Linux and with mingw32 cross-compiles.TODO:
$datadirand the .so into$libdirto make it easier to follow the Debian Java policy.